Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Upgrade dependencies #16741

Merged
merged 43 commits into from
Feb 9, 2025
Merged

Code Quality: Upgrade dependencies #16741

merged 43 commits into from
Feb 9, 2025

Conversation

hez2010
Copy link
Member

@hez2010 hez2010 commented Jan 27, 2025 •
edited
Loading

Upgrade to .NET 9
Upgrade to WASDK 1.6
Upgrade to CommunityToolkit.WinUI 8.2
Upgrade to CsWinRT 2.2
Migrate to slnx (while still keeping sln for CI now)
Use centralized nuget package version management
Use new Microsoft.UI.Content metadata

Known issues:

  • TotalLaunchCount will be reset as we implement a different approach for counting this
  • slnx won't work in CI until .NET SDK 9.0.200 is out
  • Scroll via middle click
  • Mouse cursors
  • Random crashes while navigating, this is due to a memory safety issue of CsWinRT, a workaround to this will be pushed in a following PR

Resolved / Related Issues

Supersedes #16156
Supersedes #16557
Closes #14826
Closes #16705

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

yaira2
yaira2 reviewed Jan 27, 2025
View reviewed changes
@yaira2 yaira2 changed the title Upgrade dependencies Code Quality: Upgrade dependencies Jan 27, 2025
@hez2010
Copy link
Member Author

hez2010 commented Jan 27, 2025

I temporarily brought back the sln for CI.

@hez2010
Copy link
Member Author

hez2010 commented Jan 27, 2025

CI is passing

@Lamparter
Copy link
Contributor

This PR also supersedes #16557 and closes #14826

@Lamparter
Copy link
Contributor

By the way, the work you put into this is amazing and the fact that it works is jaw-dropping 😮

yaira2
yaira2 reviewed Jan 27, 2025
View reviewed changes
@hez2010
Copy link
Member Author

hez2010 commented Feb 7, 2025 •
edited
Loading

I think I have resolved most feedbacks. PTAL.
Some missing features and the random crashes on navigation will be addressed in a following PR.

yaira2
yaira2 previously approved these changes Feb 7, 2025
View reviewed changes
@0x5bfa
Copy link
Member

0x5bfa commented Feb 7, 2025

Looks like build is failing (prob Vanara Extensions missing?), can you resolve?

@hez2010
Copy link
Member Author

hez2010 commented Feb 8, 2025

Ready for merging now.

yaira2
yaira2 previously approved these changes Feb 9, 2025
View reviewed changes
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 9, 2025
@files-community-bot
Copy link
Contributor

✅ Successfully formatted XAML files.

@yaira2 yaira2 merged commit 273c947 into files-community:main Feb 9, 2025
@hez2010 hez2010 mentioned this pull request Feb 9, 2025
Merged
@Lamparter Lamparter mentioned this pull request Feb 15, 2025
Merged
@ferrariofilippo ferrariofilippo mentioned this pull request Feb 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lamparter Lamparter Lamparter requested changes

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
4 participants
@hez2010 @Lamparter @0x5bfa @yaira2